From 3af200a8475c2ccac2169af41230be4fe7b131b1 Mon Sep 17 00:00:00 2001 From: Sebastian Bularca Date: Tue, 21 Apr 2026 00:01:34 +0200 Subject: [PATCH] rsp for types should be with the project --- Runtime/DialogLineLibrary.cs | 2 +- Runtime/IEncounterKind.cs | 41 +----------------------------------- Runtime/IRewardKind.cs | 26 ----------------------- 3 files changed, 2 insertions(+), 67 deletions(-) diff --git a/Runtime/DialogLineLibrary.cs b/Runtime/DialogLineLibrary.cs index 467cc04..e1138cc 100644 --- a/Runtime/DialogLineLibrary.cs +++ b/Runtime/DialogLineLibrary.cs @@ -22,7 +22,7 @@ namespace Jovian.EncounterSystem { } EnsureCache(); - return cache.TryGetValue(id, out var text) ? text : null; + return cache.GetValueOrDefault(id); } public void InvalidateCache() { diff --git a/Runtime/IEncounterKind.cs b/Runtime/IEncounterKind.cs index 725e5d1..d61a30c 100644 --- a/Runtime/IEncounterKind.cs +++ b/Runtime/IEncounterKind.cs @@ -7,46 +7,7 @@ namespace Jovian.EncounterSystem { } [Serializable] - public class CombatKind : IEncounterKind { - public string enemyGroupId; - public string rewardTableId; - } - - [Serializable] - public class QuestKind : IEncounterKind { + public partial class QuestKind : IEncounterKind { public EncounterLink nextEncounter; - public string questTitle; - } - - [Serializable] - public class SocialKind : IEncounterKind { - public string npcId; - public string factionId; - public int reputationDelta; - } - - [Serializable] - public class PuzzleKind : IEncounterKind { - public string puzzleId; - public int difficultyClass; - } - - [Serializable] - public class ExplorationKind : IEncounterKind { - public int perceptionDC; - } - - [Serializable] - public class TutorialKind : IEncounterKind { - public string tutorialId; - } - - [Serializable] - public class HazardKind : IEncounterKind { - public int damageAmount; - } - - [Serializable] - public class OtherKind : IEncounterKind { } } diff --git a/Runtime/IRewardKind.cs b/Runtime/IRewardKind.cs index c1060ca..ad5fff3 100644 --- a/Runtime/IRewardKind.cs +++ b/Runtime/IRewardKind.cs @@ -4,30 +4,4 @@ namespace Jovian.EncounterSystem { /// Polymorphic payload on a . Add a new kind by implementing this interface. public interface IRewardKind { } - - [Serializable] - public class CurrencyRewardKind : IRewardKind { - public string currencyId; - public int amount; - } - - [Serializable] - public class ItemRewardKind : IRewardKind { - public string itemId; - public int quantity; - } - - [Serializable] - public class ExperienceRewardKind : IRewardKind { - public int amount; - } - - [Serializable] - public class UnlockableRewardKind : IRewardKind { - public string unlockableId; - } - - [Serializable] - public class OtherRewardKind : IRewardKind { - } }